Stephen Sherratt

Results 106 comments of Stephen Sherratt
trafficstars

I guess it depends on how we measure the MVP, and whether the release process of the affected package is just making an archive of the repo at the given...

I checked and in this case the archive is just a snapshot of the repo.

Good point; it's not sufficient to detect when the first word of the command is `dune` and replace it with the value of `argv[0]`. Setting `PATH` is also insufficient as...

@kit-ty-kate good point. And the lockdir does contain a lockfile for dune when a project's dependencies depend on dune, so we should be building dune as part of the project's...

> That can't work because the dune that will be build will read/write metadata in a different format. Which metadata files are you referring to? If it's just metadata files...

But why does the dune that's orchestrating the build need to read the `dune-package` files of individual packages from the project's dependencies? Dependencies don't need to build with dune at...

For packages in the current workspace I think it makes sense to use the dune the user already has (ie. the one orchestrating the build). But for packages in the...

Why is it important that the outer dune be able to read metadata generated by the inner dune? Not all packages build with dune and the outer dune can still...

Wait did you mean to say that packages that _aren't_ built with dune rely on findlib to provide partial metadata? I imagine we wouldn't need findlib when working with packages...

Makes sense. Can you elaborate on the advanced dune features that will take advantage of cases where non-workspace dependencies build with dune (or point to documentation). Also it sounds like...