dune icon indicating copy to clipboard operation
dune copied to clipboard

Published 20 hours ago • verified publisher icon ocaml

Allow include in install stanza

Open gridbugs opened this issue 3 years ago • 1 comments
trafficstars

Closes https://github.com/ocaml/dune/issues/256

gridbugs avatar Sep 08 '22 16:09 gridbugs

There was a failing test because this removes the dependency cycle reported in https://github.com/ocaml/dune/issues/4345, where copying a file from a parent directory with the copy_files stanza in a public library caused a dependency cycle. I've removed the test because it looks like this change accidentally fixes the bug reported in that issue.

gridbugs avatar Sep 09 '22 08:09 gridbugs

Please can you add a changelog?

Alizter avatar Oct 02 '22 03:10 Alizter

LGTM. Pleasantly surprised on how cleanly you managed to tack this on.

How about adding this to (dirs ..) as well? Should hopefully be nice and simple.

This should already work. I've added a test.

gridbugs avatar Oct 10 '22 13:10 gridbugs