dune icon indicating copy to clipboard operation
dune copied to clipboard

Add support for assembly language for foreign_stubs

Open samoht opened this issue 5 years ago • 1 comments
trafficstars

The doc for foreign_stubs says:

language specifies the source language, where c means C and cxx means C++. In future, more languages may be supported.

It would be nice to add support for .S files too ; generally they can just be passed to the underlying C compiler just fine ; I'm not fully sure of what should be the assembly flags. I think keeping the flags as C by default should generally work.

samoht avatar Apr 08 '20 13:04 samoht

Indeed. That requires #3346

ghost avatar Apr 09 '20 11:04 ghost

@gridbugs do you think this is still worth doing given that we have custom objects?

rgrinberg avatar Dec 21 '22 20:12 rgrinberg

I don't think this is worth doing anymore as one can now compile the assembly files to object files with a custom rule and then include them with (extra_objects ...). For posterity, the relevant part of the documentation is https://dune.readthedocs.io/en/stable/concepts.html?highlight=extra_objects#extra-objects-1

gridbugs avatar Dec 22 '22 07:12 gridbugs