Stephen Sherratt

Results 106 comments of Stephen Sherratt
trafficstars

Why is this necessary for MVP?

That sounds reasonable. Do you think we should make it an error to attempt to lock a project with dependencies in its `dune-project` file that are pinned in the opam...

But specifically when running `dune pkg lock`, if there are packages pinned in the opam file but not in dune-project or dune-workspace, we know that the outcome will either be...

It's only a blocker in the sense that building ocaml.org is one of the goals of the package management MVP (though in this case the problem is with ocaml.org).

I think for this issue it will be sufficient to send a PR to ocaml.org adding pins in their dune file.

Why is it that putting the pins in the workspace file will allow users to avoid using dune pkg?

You mean putting the pins in a custom workspace file other than `dune-workspace` which can be enabled with a command-line argument?

@tmattio I have created a PR adding a workspace file here: https://github.com/ocaml/ocaml.org/pull/2105

Are you referring to this change: https://github.com/ocaml/dune/pull/9472 Can you give some details about `dune.configurator` not being supported. This is news to me. Also what do you mean by `dune.configruator` as...

Ah I see. The 3.13.0 release does include https://github.com/ocaml/dune/pull/9472 as described [here](https://github.com/ocaml/dune/blob/21f904250f8bc27abbeafadf70682aceb198b1e3/CHANGES.md?plain=1#L39), which checks for opam-compatible package names inside a package's `depends` field. Packages in your workspace may still be...