Shelley Vohr

Results 346 comments of Shelley Vohr

@p120ph37 please fill out the PR template you removed in order for us to continue reviewing this PR.

@tristan957 this is happening becuase your local Node.js version is too new for Webpack - it's not an Electron issue. Try using v16 LTS, it should work. See https://stackoverflow.com/questions/69394632/webpack-build-failing-with-err-ossl-evp-unsupported

@pvrobays interesting - looks like it _only_ affects Windows. Do you happen to know when it started?

OK - looks like this problem is about the message box. If you switch to ``` const response = await dialog.showMessageBox(mainWindow, { type: "question", title: "Wanna leave?", message: "Leave Site?",...

Stacktrace ``` [62775:0801/182003.139929:FATAL:navigation_request.cc(6430)] Check failed: policy->CanAccessDataForOrigin(process_id, origin_with_debug_info.first). 0 Electron Framework 0x0000000137308d42 base::debug::CollectStackTrace(void**, unsigned long) + 18 1 Electron Framework 0x00000001372260a3 base::debug::StackTrace::StackTrace() + 19 2 Electron Framework 0x000000013723fc27 logging::LogMessage::~LogMessage() + 183...

@mxschmitt could you provide a repro that's stand-alone runnable with Fiddle? That one isn't at the moment it doesn't seem 🤔 a repro repo would also be fine! fwiw it's...

This appears to have been made possible by https://github.com/electron/electron/pull/9507, so i'm going to go ahead and close this.

I think we need to add `chrome/browser/ui/color/win/native_chrome_color_mixer_win.cc` to `chromium_src/BUILD.gn`

I added the above code snippet to the stock Fiddle and could not reproduce. To try and repro, I: 1. Ran the Fiddle 2. Clicked "print me" 3. Clicked "Save...

@schetle can you please provide an example manifest for this fiddle? As is it will error becuase the manifest is missing.