Shelley Vohr

@tony-go tests can be run as a rule with just the node executable, so `out/Debug/node /path/to/test/file`. If you do want to use the test runner, you can also just do...

@Flarna hmm - that's strange since theres a `can_call_into_js()` immediately prior: https://github.com/nodejs/node/blob/6932fb8bac3a4caf3f3fabee0a595a077f477f63/src/api/callback.cc#L103

Looks like we're still having issues - when we run `sequential/test-vm-timeout-escape-promise-module-2` _after_ applying https://github.com/nodejs/node/commit/d2cf01d7566a9b09a4bfb22f6f2c03601c973086 we see this: ``` # # Fatal error in ../../v8/src/execution/microtask-queue.cc, line 182 # Debug check failed:...

@santigimeno does it not happen against canary when running `parallel/test-vm-timeout-escape-promise-2` or `sequential/test-vm-timeout-escape-promise-module-2`? That's where we see it when running with our embedded Node.js instance 🤔 - src/module_wrap.cc#L389 - src/node_contextify.cc#L945 these...

Looks like it 🤔 at least, it looks like it's specific to embedded Node.js and i haven't been able to repro it on your canary branch Tracked it down to...

@santigimeno i determined it's related to `v8::Isolate::SafeForTerminationScope`, which i think is missing somewhere for nested microtasks. Electron starts Node.js with `only_terminate_in_safe_scope` set to `true`, which triggers this error after https://chromium-review.googlesource.com/c/chromium/src/+/3620285...

hmm @targos - it pulls information from your local ncu configuration 🤔 i have the normal setup for myself and it finds that i'm `codebytere` successfully. In re. the second...

thanks @targos - this stuff is hard to test except in action so i actually welcome the spam 😛 I'll check into this and figure out how we might better...

@targos this should be in a bit better shape now - i may also swap some more things to run asynchronously and need to figure out a better way to...

@targos rebased and updated a few things if you're willing to give this another spin on your next release!