Shelley Vohr

Results 346 comments of Shelley Vohr

@darac-10 as mentioned above, we already know precisely why this is occurring. It's simply that we don't know how to address the problem. https://github.com/electron/electron/issues/32857#issuecomment-1039117399

@jameshfisher pretty sure this is just a docs update - you should be able to use the new syntax just fine. What this error is saying (correctly) is that `mandatory`...

@jameshfisher hmm ok i'll check into it and see what i come up with :)

This is what i see running your repro: which appears to be centered as expected.

Thanks for reporting this and helping to make Electron better! Because of time constraints, triaging code with third-party dependencies is usually not feasible for a small team like Electron's. Would...

@IAmHughes go for it...it was super fun to make, would love for people to improve on it!

the issue there @moshfeu is that i didn't use a library; so i can't hook into that library's functionality without rewriting a lot of underlying logic

Sure! i made this issue for someone else to pick up intentionally :)

oh TIL! i wrote this thing a while ago so it seems it's time for some updates 😆 i'll try to get to this at a Soon Time™️

We don't use Bazel or Blaze - we use Ninja with GN. We've updated some things recently - can you try again with latest electron master and latest build-tools?