Shelley Vohr
Shelley Vohr
@vitekcerny this repo requires commits to [be signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification). Once that's done, i think we can get this merged :)
Unfortunately there's not much we can do here - this function is directly plumbed to [`EnumeratePrinters`](https://source.chromium.org/chromium/chromium/src/+/main:printing/backend/print_backend.h;l=332;bpv=1;bpt=1?q=EnumeratePrinters&sq=package:chromium&type=cs) in Chromium. You should open an issue at https://issues.chromium.org/issues, and when they fix it...
@gdavidkov do you plan to pursue these changes? This PR will be closed in 10 days if there's no response.
Looks like this happened here: https://github.com/electron/electron/compare/v25.0.0-nightly.20230330...v25.0.0-nightly.20230331 - likely https://github.com/electron/electron/commit/3fa03977c7f5be9442b356ae39dd310276314dce
Electron 20 isn't supported and hasn't been in some time. For us to continue triaging this issue, it must be present on a [currently supported](https://www.electronjs.org/docs/latest/tutorial/electron-timelines) version of Electron. This issue...
We haven't gotten a response to our questions in our comment above. With only the information that is currently in the issue, we don't have enough information to take action....
This was actually addressed as a side effect of https://github.com/electron/electron/pull/42056 - as of this PR, you can pass in double values and they will be rounded to the nearest number...
Looks like it's related to https://github.com/electron/electron/pull/41256 being in 30 and not https://github.com/electron/electron/pull/41326
@Stanzilla this was fixed by https://github.com/electron/electron/pull/43078 - it's been backported to 31 and 32 and should be out soon!
> "Grrr! A popup blocker may be preventing the application from opening the page. If you have a popup blocker, try disabling it to open the window." I've never seen...