Chinmay Garde

Results 244 comments of Chinmay Garde

From Triage: This looks like a benign change that seems to be hard to test and follows patterns consistent with the rest of the code. It's low risk, fixes crashes...

Can you attach a systrace or observatory trace for that? That should tell us more about whats happening and how we can fill in the blanks.

That seems to be a wait for the GPU to finish work. We usually capture and instrument a GPU frame for such cases. We could add a trace around the...

> So the performance solution here would be to optimize what is happening on the raster thread? Unfortunately, it's not quite that simple. It could be that the application has...

From Triage: @sealesj Is this stale or are you still looking for a review. @zanderso wasn't sure which PR to review.

Depends on https://github.com/flutter/flutter/pull/104128

From Triage: Looks like the conversation here didn't come to a clear conclusion on direction. Are we still making progress on this?

Both I guess. Couldn't tell if there was consensus to make progress on this patch.

Ping @ColdPaleLight. Is there anything to do to unblock making progress on this? We'd really like to work on this as it is a high priority task but don't want...

| what would be the trigger point in the engine for when the Flutter UI is dismissed ? Perhaps `PlatformView::OnPlatformViewDestroyed`?