Chinmay Garde

Results 244 comments of Chinmay Garde

> if I can depend on Android to always fire the OnComplete This isn't documented. But following along the Android code seems to indicate that it does.

This will not land as-is. I am splitting it up into smaller patches.

Yeah. Recycling is table stakes. I'm landing bits and pieces of this patch at the moment and I still expect to have a flag for comparison.

I added a unit-test for just the [toolkit in this patch](https://github.com/flutter/engine/pull/51334/files#diff-521d7c59c3f721b259f094c760c2613e16e889b0f24702280924466109e3b0b0R733). I am able to create hardware buffers in a unit-test just fine. We can test the minutia in that...

I just realized we can also move the binder transaction (SurfaceTransaction::Apply) to a background thread.

Closing this as most of it has landed and the new patch isn't going to build on this.

xref https://github.com/flutter/engine/pull/52087

Specifying the target to et also seems to be more fussy than ninja. I can specify just impeller_unittests (the executable name) directly to ninja and it seems to figure out...

> This is WAI so that we don't use/rely on global target names in the future. That seems like an unnecessary degradation of user experience to solve a problem that...