Chinmay Garde

Results 244 comments of Chinmay Garde

The linked issue has been addressed (though not thoroughly documented). Are there any blockers to further progress here?

BTW, the fragment shader stuff landed and rolled into the framework. @Piinks The cross referenced PR landed. Can this issue be resolved?

From Triage: We are not sure this is a blocker. Lowering the priority. Please bump it back up if I am mistaken.

Right, the approximation is just an arbitrary number right now. Will have to be adaptive or precomputed for known paths.

Update: [We have some support for adaptive subdivision](https://github.com/flutter/engine/blob/030950f3070c370b5c76e8c67642c4839ee3dd37/impeller/entity/geometry.cc#L420) now but it is not uniformly applied. The next step is to do a pass for all geometry types.

I think we need to get our hands on this device and attempt to reproduce this issue. There isn't enough information here to make progress and we are speculating.

I don't think Flutter can take a screenshot of platform provided textures today. Especially if those textures are from protected sources. I believe the linked issue was for tests. cc...

Skia builds shader libraries from MSL source at runtime while Impeller compiles them to AIR metallibs. We need to embed the sources explicitly in perhaps the profile mode using `-fembed-sources`....