engine

engine copied to clipboard

…4735)

Exposes runWithEngine in FlutterViewController as suggested by jmagman in #74735 Fixes: https://github.com/flutter/flutter/issues/74735

Removing [engine setViewController:self]; because view is not loaded, but in that function controller is saved. Later, when the view is loaded (loadView) passed as an argument controller is checked against the saved controller and since they match, the nil view is not replaced with a new view.

Pre-launch Checklist

• [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
• [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
• [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
• [x] I listed at least one issue that this PR fixes in the description above.
• [x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
• [x] I updated/added relevant documentation (doc comments with ///).
• [x] I signed the [CLA].
• [x] All existing and new tests are passing.

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

From PR review triage: It looks like this PR needs feedback from @cbracken.

From Triage: Looks like the conversation here didn't come to a clear conclusion on direction. Are we still making progress on this?

@chinmaygarde are you asking the reviewers or me?

Both I guess. Couldn't tell if there was consensus to make progress on this patch.

we're going to want to add a devicelab test for this in the framework as well, which we'll need to do in a separate patch.

It could look like module_test_ios but using flutter build macos-framework integration and need an example app like https://github.com/flutter/samples/tree/main/add_to_app/prebuilt_module