Janghyun(JK)Kim

Results 11 issues of Janghyun(JK)Kim

Issue overview -------------- I think it is obvious that this is happening after switching to 1.6. I use `sync project measures with library` button (marked in the screenshot below) a...

severity - Normal Bug :bug:

Pull request overview --------------------- **this is ready for your review! @ChristopherCaradonna** **change highlights** - https://github.com/NREL/ComStock/pull/162 - https://github.com/NREL/ComStock/pull/177 - https://github.com/NREL/ComStock/pull/166 - https://github.com/NREL/ComStock/pull/167 - unit test revised - added detailed cfm/ton violation...

upgrade measure

Pull request overview --------------------- **this is ready for your review! @ChristopherCaradonna** - upsizing algorithm fix - coming from Jeff Munk's comment summarized below: ![image](https://github.com/NREL/ComStock/assets/26775789/107919ed-e5dc-42e3-83b2-73b97564f3ef) - made changes in the VRF...

upgrade measure

just did a quick debugging of csv with @ChristopherCaradonna and found out - this output var `calc.percent_savings.electricity.cooling.energy_consumption..percent` (from `ComStock wide.csv`) has a dimensionless unit rather than percent - quick calc...

bug

Pull request overview --------------------- This became a very complicated change including multiple sub-PRs and multiple updates on the same thing. But below are the summary of changes: - `upgrade_hvac_add_heat_pump_rtu` measure...

upgrade measure

Pull request overview --------------------- - putting this before I forget - noticed our HPRTU model might have coil rated flow with value A while variable fan max flow with value...

bug
upgrade measure

Pull request overview --------------------- - converting `Coil:_:DX:MultiSpeed` to `Coil:_:DX:VariableSpeed` object for advanced heat pump RTU modeling - based on how I'm understanding, we had multiple performance issues with multi-spd coil...

upgrade measure

- came across while working on something else - and unsure if it was intended - but isn't this below double counting? so for like FCU DOAS, FCU airflow gets...

- came across while working on something else - and unsure who's even using this output variable but don't we want baseboard/electric-coil capacities added to this line? https://github.com/NREL/ComStock/blob/7198d82540d5c1131ccccb6739224a181f9b9f2d/measures/comstock_sensitivity_reports/measure.rb#L3285

I was debugging a model and found this weird. below is my "theory": - it was comstock's full service restaurant model that has PSZs in dining - this below is...