ComStock
ComStock copied to clipboard
SDR: HPRTU measure: setting fan max flow the same as coil rated flow
Pull request overview
- putting this before I forget
- noticed our HPRTU model might have coil rated flow with value A while variable fan max flow with value B (i.e., so not matching)
- this might threw many errors during simulation such like this below:
** Warning ** GetDXCoils: Coil:Heating:DX:MultiSpeed="ZONE SMALLHOTEL STAIR A - STORY GROUND PSZ-AC HEAT PUMP COIL" curve values
** ~~~ ** ... Defrost Energy Input Ratio Function of Temperature Curve Name = ZONE SMALLHOTEL STAIR A - STORY GROUND PSZ-AC DEFROST_EIR output is not equal to 1.0 (+ or - 10%) at rated conditions.
** ~~~ ** ... Curve output at rated conditions = 0.152
** Severe ** AirLoopHVAC:UnitarySystem = ZONE SMALLHOTEL STAIR A - STORY GROUND RTU SZ-VAV HEAT PUMP
** ~~~ ** ... air flow rate = 1.2720342E-002 in fan object ZONE SMALLHOTEL STAIR A - STORY GROUND PSZ-AC VFD FAN is less than the maximum HVAC system air flow rate in cooling mode.
** ~~~ ** The Cooling Supply Air Flow Rate is reset to the fan flow rate and the simulation continues.
** Severe ** AirLoopHVAC:UnitarySystem = ZONE SMALLHOTEL STAIR A - STORY GROUND RTU SZ-VAV HEAT PUMP
** ~~~ ** ... air flow rate = 1.2720342E-002 in fan object ZONE SMALLHOTEL STAIR A - STORY GROUND PSZ-AC VFD FAN is less than the maximum HVAC system air flow rate in heating mode.
** ~~~ ** The Heating Supply Air Flow Rate is reset to the fan flow rate and the simulation continues.
- So this PR is trying to match fan max flow with coil rated flow
- Also, added an unit test to check that
- We can change the base branch to something else later
@ChristopherCaradonna targeting this to be reflected in the next release
Pull Request Author
This pull request makes changes to (select all the apply):
- [ ] Documentation
- [ ] Infrastructure (includes apptainer image, buildstock batch, dependencies, continuous integration tests)
- [ ] Sampling
- [ ] Workflow Measures
- [x] Upgrade Measures
- [ ] Reporting Measures
- [ ] Postprocessing
Author pull request checklist:
- [x] Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
- [x] Added tests for new measures
- [x] Updated measure .xml(s)
- [ ] Register values added to
comstock_column_definitions.csv - [ ] Both
options_lookup.tsvfiles updated - [ ] 10k+ test run
- [ ] Change documentation written
- [ ] Measure documentation written
- [ ] ComStock documentation updated
- [ ] Changes reflected in example
.ymlfiles - [ ] Changes reflected in
README.mdfiles - [ ] Added 'See ComStock License' language to first two lines of each code file
- [ ] Implements corresponding measure tests and indexing path in
test/reporting_measure_tests.txt,test/workflow_measure_tests.txt, ortest/upgrade_measure_tests.txt - [ ] All new and existing tests pass the CI
Review Checklist
This will not be exhaustively relevant to every PR.
- [ ] Perform a code review on GitHub
- [ ] All related changes have been implemented: data and method additions, changes, tests
- [ ] If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
- [ ] Reviewed change documentation
- [ ] Ensured code files contain License reference
- [ ] Results differences are reasonable
- [ ] Make sure the newly added measures has been added with tests and indexed properly
- [ ] CI status: all tests pass