ComStock
ComStock copied to clipboard
EUSS HP-RTU measure updates
Pull request overview
This became a very complicated change including multiple sub-PRs and multiple updates on the same thing. But below are the summary of changes:
-
upgrade_hvac_add_heat_pump_rtumeasure (and corresponding unit tests) refactored and updated -
comstock_sensitivity_reportsmeasure updated to include cycling impacts -
these sub-PRs include some major context of the changes
- https://github.com/NREL/ComStock/pull/222
- https://github.com/NREL/ComStock/pull/204
- https://github.com/NREL/ComStock/pull/198
- https://github.com/NREL/ComStock/pull/167
- https://github.com/NREL/ComStock/pull/166
- https://github.com/NREL/ComStock/pull/177
- https://github.com/NREL/ComStock/pull/162
- also including Chris' updates regarding Cold Climate Heat Pump Challenge updates
-
this PR also includes some other stuffs:
create_measure update to 3.8, os stds update to 0.6.1, and maybe more... -
updated some shared/test models to 3.8
-
I couldn't avoid including these other xml updates. sorry.
Pull Request Author
This pull request makes changes to (select all the apply):
- [ ] Documentation
- [ ] Infrastructure (includes apptainer image, buildstock batch, dependencies, continuous integration tests)
- [ ] Sampling
- [ ] Workflow Measures
- [x] Upgrade Measures
- [x] Reporting Measures
- [ ] Postprocessing
Author pull request checklist:
- [ ] Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
- [x] Added tests for new measures
- [x] Updated measure .xml(s)
- [ ] Register values added to
comstock_column_definitions.csv - [x] Both
options_lookup.tsvfiles updated - [ ] 10k+ test run
- [ ] Change documentation written
- [x] Measure documentation written
- [ ] ComStock documentation updated
- [ ] Changes reflected in example
.ymlfiles - [x] Changes reflected in
README.mdfiles - [ ] Added 'See ComStock License' language to first two lines of each code file
- [ ] Implements corresponding measure tests and indexing path in
test/measure_tests.txtor/andtest/resource_measure_tests.txt - [ ] All new and existing tests pass the CI
Review Checklist
This will not be exhaustively relevant to every PR.
- [ ] Perform a code review on GitHub
- [ ] All related changes have been implemented: data and method additions, changes, tests
- [ ] If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
- [ ] Reviewed change documentation
- [ ] Ensured code files contain License reference
- [ ] Results differences are reasonable
- [ ] Make sure the newly added measures has been added with tests and indexed properly
- [ ] CI status: all tests pass