EUSS HP-RTU measure update

Pull request overview

this is ready for your review! @ChristopherCaradonna

change highlights

• https://github.com/NREL/ComStock/pull/162

• https://github.com/NREL/ComStock/pull/177

• https://github.com/NREL/ComStock/pull/166

• https://github.com/NREL/ComStock/pull/167

• unit test revised

  • added detailed cfm/ton violation check
  • fixed broken tests (e.g., weather file)

• lower bound cfm/ton adjustment revised

  • adjusting airflow rather than capacity: https://github.com/NREL/ComStock/pull/163/commits/24e46f09e62cdf6e5b303c14bd8959be18ee144a
  • unit test also added: https://github.com/NREL/ComStock/pull/163/commits/afb87b2db093448535c43b01ad63952c082ddf03

• rated COP adjustment based on reference cfm/ton: https://github.com/NREL/ComStock/pull/163/commits/ae10a15020620fc3b10829d98869efabd41016f8

• implementing rated COP degradation for larger units (for both advanced and standard performance HPRTUs):

  • trying to be consistent with standard performance implementation.
  • steps taken:

    • gathered AHRI rated COPs from Daikin spec sheets.

    • adjusted AHRI rated COPs by ~5% to exclude blower power and blower heat gain

    • ~5% is coming from calculating adjusted COPs from Lennox's spec sheets that include blower power tables.

    • results shown below

      • advanced performance: ee995cd

      

      • standard performance: 80be90c

      

• single model and 10k test runs completed. Updates reflected in the measure doc.

  • new results are reflected with track changes.
  • if there are two similar figures next to each other, then the top one if 'before' and bottom one is 'after'

Pull Request Author

This pull request makes changes to (select all the apply):

• [ ] Documentation
• [ ] Infrastructure (includes singularity image, buildstock batch, dependencies, continuous integration tests)
• [ ] Sampling
• [ ] Workflow Measures
• [X] Upgrade Measures
• [ ] Reporting Measures
• [ ] Postprocessing

Author pull request checklist:

• [X] Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
• [x] Added tests for new measures
• [X] Updated measure .xml(s)
• [ ] Register values added to comstock_column_definitions.csv
• [ ] Both options_lookup.tsv files updated
• [x] 10k+ test run
• [ ] Change documentation written
• [X] Measure documentation written
• [ ] ComStock documentation updated
• [ ] Changes reflected in example .yml files
• [ ] Changes reflected in README.md files
• [ ] Added 'See ComStock License' language to first two lines of each code file
• [ ] Implements corresponding measure tests and indexing path in test/measure_tests.txt or/and test/resource_measure_tests.txt
• [ ] All new and existing tests pass the CI

Review Checklist

This will not be exhaustively relevant to every PR.

• [ ] Perform a code review on GitHub
• [ ] All related changes have been implemented: data and method additions, changes, tests
• [ ] If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• [ ] Reviewed change documentation
• [ ] Ensured code files contain License reference
• [ ] Results differences are reasonable
• [ ] Make sure the newly added measures has been added with tests and indexed properly
• [ ] CI status: all tests pass