CommanderRoot
CommanderRoot
I apologize for not signing the CLA sooner, must have somehow missed it
The reason I used `substring()` [instead](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substring#the_difference_between_substring_and_substr) of `slice()` in these instances is because the second parameter is normally positive but it **could** be negative. Example: ``` "0123456789".substr(0, -1) == ""...
substring() and slice() are very similar but [differ](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substring#differences_between_substring_and_slice) in some regards. I personally prefer slice() over substring() as it's imo stricter. There is no "re-sorting" of arguments. It's also shorter...
The PR is still relevant
It varies but it's between 30 - 50 unique users per month. Back when I initially created this PR it was quite a bit more as Twitch removed their exclusivity...
I have now signed the CLA as requested
It removes a deprecation warning in the IDE. But you're right, unless the function gets removed by browsers or other software which uses this code there is nothing broken. As...
This PR is still relevant
I have rebased the commits as requested
I have rebased the commits and resolved the merge conflicts