jitsi-meet icon indicating copy to clipboard operation
jitsi-meet copied to clipboard

refactor: replace deprecated String.prototype.substr()

Open CommanderRoot opened this issue 3 years ago • 11 comments

String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated. .substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.

CommanderRoot avatar Mar 22 '22 08:03 CommanderRoot

Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

jitsi-jenkins avatar Mar 22 '22 08:03 jitsi-jenkins

Jenkins please test this please.

saghul avatar Mar 25 '22 09:03 saghul

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Dec 29 '23 01:12 github-actions[bot]

This PR is still relevant

CommanderRoot avatar Dec 29 '23 01:12 CommanderRoot

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Mar 30 '24 01:03 github-actions[bot]

THis needs a rebase. Sorry it fell through the cracks :-/

saghul avatar Apr 05 '24 08:04 saghul

I have rebased the commits as requested

CommanderRoot avatar Apr 05 '24 12:04 CommanderRoot

Jenkins please test this please.

saghul avatar Apr 06 '24 21:04 saghul

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jul 06 '24 01:07 github-actions[bot]

I have rebased the commits and resolved the merge conflicts

CommanderRoot avatar Jul 06 '24 14:07 CommanderRoot

Jenkins please test this please.

saghul avatar Jul 06 '24 17:07 saghul