aws-sdk-js icon indicating copy to clipboard operation
aws-sdk-js copied to clipboard

chore: replace deprecated String.prototype.substr()

Open CommanderRoot opened this issue 3 years ago • 2 comments

String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated. .substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.

Checklist
  • [x] npm run test passes
  • [ ] .d.ts file is updated
  • [ ] changelog is added, npm run add-change
  • [ ] run bundle exec rake docs:api and inspect doc/latest/index.html if documentation is changed
  • [ ] run npm run integration if integration test is changed
  • [ ] non-code related change (markdown/git settings etc)

CommanderRoot avatar Mar 25 '22 23:03 CommanderRoot

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.

github-actions[bot] avatar Aug 17 '23 00:08 github-actions[bot]

The PR is still relevant

CommanderRoot avatar Aug 17 '23 00:08 CommanderRoot