Adam

Results 212 comments of Adam

> Thirdly because of how the serializer api works atm it always creates a new instance. This makes it impossible to put change events on the settings class itself because...

> We could also use composition: Could you give an example what the advantage of this design would be? Because it seems more complex / harder to understand than just...

> Some advantages: > > * Setting class itself is just a POCO. > * Allows us to move the change events to the settingcontainer instead of keeping them in...

In that case, the code that serializes any of these settings should [choose the XmlSerializer specifically](https://github.com/AdamsLair/duality/blob/6489aa2de7c652ca7959d47a793b69539425b46c/Source/Core/Duality/Serialization/Serializer.cs#L977) via `preferredSerializer`, avoiding that any future or project-specific change will cause them to use...

Note: As far as I can see from #856, the file extension change to `.xml` is done only for the new `EditorAppData.xml`, while the others still use `.dat`. @Barsonax Depending...

## Progress - Updated the core to use Duality Serializers and settings container object for all user and app data via #856 - Updated the editor to use Duality Serializers...

Worked on the API a bit while looking into #868 and I think we should keep in mind a slight design trap we might fall into: - Even though the...

Fixed some behavior that was broken during the `SettingsContainer` refactoring in commits https://github.com/AdamsLair/duality/commit/ea5acb367fd2bcbc06accda76e92ff43b006f1b5 and https://github.com/AdamsLair/duality/commit/1531037d8f57f621e05d69d2079a75a74175afbd. Unfortunately, this invalidates some of the benefits we got through the `SettingsContainer` abstraction: - The...

## Progress - Fixed editor settings menus selecting the container object instead of the settings instances directly (see comment above). - Fixed `Default/UserData.xml` behavior in core and editor (see comment...

I'm currently more or less in hibernation mode due to daily workload in non-OSS domains, but current progress and ToDo as documented here should be up-to-date. @Barsonax might know more,...