Ikhun Um

Results 364 comments of Ikhun Um

Changed the title of this PR to reflect the purpose. 🙇‍♂️

@Bue-von-hon Thanks for your effort. That said maintainers are working on various issues and are aware of the status of this PR, so you may not need to keep mentioning...

A straightforward workaround is to set CORS headers using `ServiceRequestContext.addAdditionalResponseHeader()` in the CORS exception hander

> ctx.additionalResponseHeaders().withMutations { builder -> `HttpHeaders` is immutable so `additionalResponseHeaders().withMutations()` will create a new headers and the mutation won't affect the additional headers in `ServiceRequestContext`. You may want to use...

@Mina-1316 It seems like there is no need to apply CORS headers when preflight requests fail because they don't reach the business logic. Do you want to set CORS headers...

> I guess that would be much bigger effort? Right, we need many changes to fully support virtual threads. Because we don't know when we will reach that goal, this...

Thread pinning will be fixed in the next Java version. https://mail.openjdk.org/pipermail/loom-dev/2024-February/006433.html We have been spending a lot of time implementing LINE's internal requirements such as xDS protocol and so on....

I've assigned https://github.com/line/armeria/issues/5219 to you. Do you want to resolve both of them at once?

Agreed. All of your ideas look nice to me.