armeria icon indicating copy to clipboard operation
armeria copied to clipboard

Test failure: `com.linecorp.armeria.server.websocket.WebSocketServiceHttp2RequestCompleteTest.closeAfterTimeoutWhenCloseFrameIsNotSent()`

Open ikhoon opened this issue 8 months ago • 2 comments

org.awaitility.core.ConditionTimeoutException: Condition was evaluated in 105 milliseconds which is earlier than expected minimum timeout 1 seconds
	at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:172)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at app//com.linecorp.armeria.server.websocket.WebSocketServiceHttp2RequestCompleteTest.closeAfterTimeoutWhenCloseFrameIsNotSent(WebSocketServiceHttp2RequestCompleteTest.java:124)
	at [email protected]/java.lang.reflect.Method.invoke(Method.java:569)
	at [email protected]/java.util.ArrayList.forEach(ArrayList.java:1511)
	at [email protected]/java.util.ArrayList.forEach(ArrayList.java:1511)

ikhoon avatar Apr 23 '25 03:04 ikhoon

@ikhoon Happy to take this issue but I can't reproduce it. I @RepeatedTest(100) this test without any failures. Do you have any more information when this might fail?

Here is the commit where I ran the test.

schiemon avatar May 14 '25 18:05 schiemon

There are two other duplicates of this issue by the way: https://github.com/line/armeria/issues?q=closeAfterTimeoutWhenCloseFrameIsNotSent and there is a solution proposal: https://github.com/line/armeria/issues/6156#issuecomment-2772631042

schiemon avatar May 14 '25 18:05 schiemon

Do you have any more information when this might fail?

I haven't looked at this in detail yet. Some flaky tests aren't hard to reproduce in the local environment.

there is a solution proposal: https://github.com/line/armeria/issues/6156#issuecomment-2772631042

I will look into the hypothesis.

ikhoon avatar Jun 19 '25 10:06 ikhoon