Ilya Grigorik

Results 296 comments of Ilya Grigorik
trafficstars

Would you be willing to pull together a PR to address this? :-)

It's possible that amqp library has been updated and API has changed. Have you tried freezing AMQP gem with an earlier version number?

@dgutov that pull conflates amqp and ActiveRecord changes. Can you make a separate commit+pull for AMQP freeze?

@jacobhummer I've not kept up with the AMQP stuff, not sure.

Related: - https://bugs.ruby-lang.org/issues/10344 - http://invalidlogic.com/2011/05/26/beware-of-error-handling-with-fibers-in-an-evented-context/

I'd be happy to accept a PR if someone wants to own it on an on-going basis.

Looks to be much simpler implementation, which is a good sign. That said, would be great to get 4.0 support! Any chance you could give it a shot and see...

Looks like this and #190 are duplicates. Any objections to closing this one in favor of #190 -- seems like we're farther ahead there.

Ah, yes.. I don't think I ever got to inject, hence the commented out spec: https://github.com/igrigorik/em-synchrony/blob/master/spec/fiber_iterator_spec.rb#L22 I'd start with getting a failed spec, and then we can iterate from there!

Humm.. yeah, this is a tricky one: ``` ruby require 'eventmachine' EM.run do EM::Iterator.new((1..5), 2).inject(0, proc{ |total,num,iter| EM.next_tick { p [total, num] total += num iter.return(total) } }, proc{ |results|...