Ilya Grigorik

Results 296 comments of Ilya Grigorik
trafficstars

Unfortunately that's not surprising. Existing TCPSocket functionality is _very_ basic, as in it only implements a few methods of the API. The SSL stuff specifically shouldn't be hard to add,...

Well, I don't think we would want to try to wrap that, we need to use the built-in EM SSL primitives.. which is actually as simple as `conn.start_tls(opts)`. Having said...

It's definitely on the backlog, and to be honest.. unlikely to be resolved. I don't think we'll be able to match the SSL API's.

EM's SSL layer and net/http SSL layer are two entirely different beasts.. Perhaps it come be made to work, but I'm not too hopeful. I have a strong feeling that...

Odd, to say the least. Are you sure your runtime is not pulling in an older version by accident?

Can't reproduce here ``` igrigorik { ~ } > ruby -v ruby 2.2.4p230 (2015-12-16 revision 53155) [x86_64-darwin15] igrigorik { ~ } > gem install em-websocket Fetching: em-websocket-0.5.1.gem (100%) Successfully installed...

Hmm, that's a gotcha. I've been running an older version of em-websocket behind haproxy, so haven't run into this. Having said that, I'm pretty sure pusherapp is running on latest...

This does what you're looking for: https://github.com/postrank-labs/goliath/blob/master/lib/goliath/websocket.rb

I'm still not sure what you're after.. If you have a specific proposal, outline it and we can discuss it. "Well written" is ambiguous :-)