Ilya Grigorik

Results 288 comments of Ilya Grigorik

@willnorris to the contrary, it is under active development! :) @yoavweiss has a nice explainer and document on status of all the related plumbing: https://github.com/yoavweiss/client-hints-infrastructure/

+1 to dropping lockfile. Can we split the last commit here into a separate PR and change this to remove and ingore the lock file?

I'm happy to push out a new release, but not sure if anything is blocking.. @nate any thoughts? In particular, it looks like jruby and rbx are having some issues...

Looks like you're missing a required gem... `gem install ruport`

Take a look at this post for estimating the size of the filter: http://www.igvita.com/2008/12/27/scalable-datasets-bloom-filters-in-ruby/ Rule of thumb, for 500K items, you need 5M bits for 1% error rate.

https://github.com/igrigorik/bloomfilter-rb/blob/master/lib/bloomfilter/native.rb#L8-20

@sporkmonger I think we have some confusion here. The "number of buckets" is the number of bits you'll allocate for the entire filter - setting that to one bit won't...

Hmm, not sure this is the right approach.. If I'm reading this correctly, you removed crc32 step and replaced it with a simple modulo? The pure Ruby version looks good,...

@n-nishizawa ah, gotcha.. missed the block callback. That's going to be a costly roundtrip. Let's see if we can make it a direct call..

Huh, well that's a fun one. Thanks for tracking this down... /me scratches head, not quite sure what's going here. I guess we could/should the built-in method: http://ruby-doc.org/stdlib-1.9.3/libdoc/zlib/rdoc/Zlib.html#method-c-crc32