em-synchrony icon indicating copy to clipboard operation
em-synchrony copied to clipboard

Use of deprecated ::Fixnum in AR connection adapter

Open Gerard-at-Streamit opened this issue 7 years ago • 2 comments
trafficstars

Since Ruby 2.4, Bignum and Fixnum have been unified into Integer (see Ruby 2.4. release). The use of Fixum generates a warning:

(....)/active_record/connection_adapters/em_mysql2_adapter.rb:27: warning: constant ::Fixnum is deprecated

Are there plans to update this?

Gerard-at-Streamit avatar Jan 18 '18 15:01 Gerard-at-Streamit

Would you be willing to pull together a PR to address this? :-)

igrigorik avatar Jan 18 '18 16:01 igrigorik

Sorry, took me some time to get back to this. Created a (very simple, but backwards compatible) PR. Note that I did not touch the Fixnum used in the spec for TCPSocket. This appears to be the only other use of Fixnum (or Bignum) in this gem.

Gerard-at-Streamit avatar Jan 26 '18 19:01 Gerard-at-Streamit