em-synchrony icon indicating copy to clipboard operation
em-synchrony copied to clipboard

Can't require 'em-synchrony/amqp'

Open hghdo opened this issue 11 years ago • 11 comments
trafficstars

Hi all I can't require 'em-synchrony/amqp' It complains:

em-synchrony/amqp.rb:189:in `<module:AMQP>': undefined method `client=' for AMQP:Module (NoMethodError)

I have amqp v1.2.1 installed.

hghdo avatar Feb 03 '14 08:02 hghdo

It's possible that amqp library has been updated and API has changed. Have you tried freezing AMQP gem with an earlier version number?

igrigorik avatar Feb 03 '14 17:02 igrigorik

I am seeing this as well with 1.1.0, 1.2.0, and 1.3.0 of the amqp gem.

myobie avatar May 21 '14 13:05 myobie

I cant say definitely, that the versions above 1.0.4 don't work. Are there any plans to support newer versions of amqp gem?

michaelkruglos avatar Jun 16 '14 13:06 michaelkruglos

From amqp's change log: AMQ::Client has been removed since v1.1.0

steventen avatar Aug 21 '14 20:08 steventen

@igrigorik

  gem 'amqp', '= 1.0.0'

does the trick.

dgutov avatar Mar 06 '15 17:03 dgutov

@dgutov that pull conflates amqp and ActiveRecord changes. Can you make a separate commit+pull for AMQP freeze?

igrigorik avatar Mar 08 '15 01:03 igrigorik

@igrigorik Sure, if you think that's preferable. I can't run the specs without the other change, though.

dgutov avatar Mar 08 '15 09:03 dgutov

@igrigorik any chance you have insight into whether updates are coming to support AMQP gem > 1.0.4? Greatly appreciated if so.

jacobhummer avatar Jan 06 '16 06:01 jacobhummer

@jacobhummer I've not kept up with the AMQP stuff, not sure.

igrigorik avatar Jan 06 '16 06:01 igrigorik

Thank you @igrigorik ! Definitely understandable. Hopefully I'll be able to have a go at it.

jacobhummer avatar Jan 06 '16 06:01 jacobhummer

I think that just removing the line ::AMQP.client = ::EM::Synchrony::AMQP::session might be enoug to make it work with newer amqp gems. I've just run the tests on Debian unstable wich contains amqp 1.6, and they passed fine.

boutil avatar Jul 06 '16 17:07 boutil