András Belicza comments

Results 106 comments of


                                            András Belicza

Looking for new maintainer(s)

Anyone noticed this issue has number #911? (Sorry for non-constructive comment). I love(d) Atom and the go-plus duo, I'm sorry to see it fade away. Indeed, having no code completion...

How to update session attributes in Store without re-adding cookie

Getting / setting values in the session is done via the [`Session`](https://godoc.org/github.com/icza/session#Session) interface, not via the `Manager`. The `Session` interface has a `Session.Attr()` method for getting a value, and a...

How to update session attributes in Store without re-adding cookie

Some additional notes after re-reading your question: Changing attributes in the session is a server side operation, it needs no client, cookie or manager updates. If another request will access...

How to update session attributes in Store without re-adding cookie

True. But that will only cause "trouble" if you have multiple (web) server nodes. The GAE (Google App Engine) Memcache store implementation solves this by requiring to call the `Manager.Close()`...

Async save to datastore incorrect

Thanks for reporting this. As a "temporary" fix, I changed the default operation to save sessions in the Datastore synchronously (before returning from the request).

Deleting and creating a new session on the same request causes dangling?

I saw your issue, just didn't have time for it yet. Will look into it soon.

Deleting and creating a new session on the same request causes dangling?

Ok, so some questions. - What session manager do you use (`session.Manager`)? The default, global one which is `session.CookieManager`? - What session store do you use? The default in-memory store...

Deleting and creating a new session on the same request causes dangling?

I'm not sure, but I guess you can easily test that (by not redirecting).

Question: The signatures of the Store interface methods

Good idea, it might have been an overlook from my part when designing the API. Similarly, if we proceed to add an `error` return value too to the `Store` methods,...

Mutual SSL Authentication

I haven't thought about it. Does anyone else need it?