Andreas Frömer

Results 116 comments of Andreas Frömer

We probably should do dumping here and progress bar on the other 😉

Hi. Thanks for reporting. Might be due to broken phar build of composer-unused.

One idea that I have right now, since the mutation is based on php-parser, is. We could introduce some kind of `LogicNormalizer` which applies de morgan's law onto a logical...

I think it should be placed here: https://github.com/infection/infection/blob/804227770afbb876b4cbd24552535ddc0cdd331a/src/Mutator/NodeMutationGenerator.php#L91-L111 Before the `$node` is passed to the mutators, we should "replace" the node with normalized logical representation. This way the hash functionality...

Or does it make more sense to have this only for logical mutators? Like here: https://github.com/infection/infection/blob/71b2fb94652da380d37ce4db8f5ed6cc6498f168/src/Mutator/Boolean/LogicalAndAllSubExprNegation.php#L77-L80 So that each logical mutator has to call some `LogicNormalizer` on the passed in...

Good finding. Generally, I would go for approach 2 first. Finding it on paper is the simplest solution for now. Writing a "truth table" test for those might be another...

https://github.com/shogo82148/actions-upload-release-asset looks good to be used if you want to stick with uploading assets and creating the release manually

Can you narrow it down to a certain vendor package? Because it's hard to detect which code structure causes this.

Thanks. I can check. But something to fix in symbol-parser most probably.

Got it. If you would be so kind to just run a PR for that patch? Would gladly just release a new version 😉