Iñaki Baz Castillo

Results 548 comments of Iñaki Baz Castillo

No need to close the issue, @buptlsp.

@buptlsp I'd appreciate if you could change those values in your local fork, test them and, if possible, come with appropriate ones (or write a PR directly if you wish).

> Please don't feel discouraged if PR wasn't merged as is, it is still useful and appreciated! Yes @buptlsp, even if you PR was not merged it was conceptually right...

> Please leave review rather than individual comments, too many notifications otherwise 🙏 I thought I was doing that but definitely I did it wrong. Sorry.

Thanks @kingqn0321. Please let's review this on next days. We have busy days at work and many things to work on.

We are super busy at work. We don't forget about this, we'll check in next days hopefully.

I cannot comment much about this yet since I don't know anything about how a native plug-in can be "installed", but from architectural point of view I think that every...

> Check the three alternatives mentioned in the description (Loading of plugins) Of course I only consider the "add some simple dynamic loading capabilities" approach. Others are not plug-ins at...

@jmillan the thing here is that worker plugins should just run on C++ without interacting with the Node/Rust layer. I agree that they should NOT be able to close transports...

> I agree though that there is no need to serialize data we are passing to the same process, but I want to reiterate the importance of limiting the access...