Iñaki Baz Castillo

Results 539 comments of Iñaki Baz Castillo

> 2/ I guess the mediasoup-worker (not the libmediasoup-worker) is the equivalent of that node native module today, right? Why can't it be integrated there then? https://mediasoup.org/faq/#is-mediasoup-a-native-addon

Honestly there is no change since 3.12.12 that could have fix this issue. Let me reopen to not forget. I think we need a fuzzer test for this class.

> probably just logging an error and resting the RateCalculator will be more appropriate error handling Defensive programming hides real bugs. We don't do that. If something should never happen...

@gitamirp any news? I assumed you patched version 3.12.12 so it's not a problem for you anymore but perhaps you updated to latest version (without patching it)?

Yes please. Add those logs and comment here when you get something. We will investigate this next week. Too busy these days.

It makes sense. Just let's us review this during this week, please.

Is this something that was not properly done when Rust layer was created? In theory DepUsrSCTP.cpp should run a `Checker` singleton (which runs the usrsctp thread) per Worker even in...

@nazar-pc perhaps you see something wrong in https://github.com/versatica/mediasoup/blob/v3/worker/src/DepUsrSCTP.cpp when running multiple mediasoup `Worker` threads in Rust? The constructor in `Worker.cpp` creates a `DepUsrSCTP::Checker` singleton, which is defined as `thread_local static...

It makes sense. IMHO the problem is not even related to usrsctp being multithreaded since we use the single thread api, so that shouldn't be the problem. The problem is...

@jmillan and me have talked long about this and we have identified the problem. I'm exposing it in detail in a new issue: https://github.com/versatica/mediasoup/issues/1352 I'm then closing this issue so...