mediasoup icon indicating copy to clipboard operation
mediasoup copied to clipboard

Add webrtc transport-cc feedback mechanism

Open kingqn0321 opened this issue 2 years ago • 8 comments

Details

1、improve the accuracy of gcc bwe when uplink network exists a big propagate jitter(eg: 100ms) 2、this optimization logic is ported from google webrtc(see: RemoteEstimatorProxy)

Rationale

1、mediasoup transport-cc feedback performance badly when uplink(webrtc-client--->mediasoup) network exists a big propagate jitter,will result in a very low GCC estimate for the webrtc-client,due to not considering disorder. 2、this optimization logic is ported from google webrtc(see: RemoteEstimatorProxy) which use a packetArrivalTimes(Map unwrapped seq -> time) buffer to send missing(arrived late due to disorder) recv delta feedback after a reordering. 3、Network simulation using Linux tc. eg: netem delay 50ms 50ms

kingqn0321 avatar Jul 10 '23 14:07 kingqn0321

Please leave review rather than individual comments, too many notifications otherwise :pray:

nazar-pc avatar Jul 10 '23 15:07 nazar-pc

Please leave review rather than individual comments, too many notifications otherwise 🙏

I thought I was doing that but definitely I did it wrong. Sorry.

ibc avatar Jul 10 '23 15:07 ibc

Thanks @kingqn0321. Please let's review this on next days. We have busy days at work and many things to work on.

ibc avatar Jul 12 '23 15:07 ibc

It's maybe similar with this pull request. https://github.com/versatica/mediasoup/pull/1088

Romantic-LiXuefeng avatar Jul 26 '23 10:07 Romantic-LiXuefeng

@ibc @jmillan sorry to interrupt,have you had time to review this code lately

kingqn0321 avatar Sep 18 '23 02:09 kingqn0321

We are super busy at work. We don't forget about this, we'll check in next days hopefully.

ibc avatar Sep 18 '23 19:09 ibc

Indeed this and https://github.com/versatica/mediasoup/pull/1088 add the same functionality, right?

jmillan avatar Jan 02 '24 09:01 jmillan