Iñaki Baz Castillo
Iñaki Baz Castillo
What is this fixing exactly? I've never seen those tests failing due to memory problems.
I think we have a test-asan task in Makefile/tasks.py. Let me please test it in 10 days when I'm back before we merge this PR just to confirm.
@penguinol, here a PR adding ASAN to Node tests: https://github.com/versatica/mediasoup/pull/1415 Perhaps we should have the same in worker tests?
> @penguinol, here a PR adding ASAN to Node tests: #1415 > > Perhaps we should have the same in worker tests? Actually we already have `make/invoke test-asan`...
@penguinol: https://github.com/versatica/mediasoup/pull/1416
@penguinol I don't see that changes in this PR fix the ASAN issues related to `RtpPacket`. Probably unrelated but those are the issues I get: https://github.com/versatica/mediasoup/pull/1416#issuecomment-2199756593
@penguinol we are addressing these and other ASAN issues in this PR: https://github.com/versatica/mediasoup/pull/1416#issuecomment-2199897238 And yes, changes include those in your PR. So thanks.
As per above discussion, can we close this PR?
> There is an alarming rise of issues along the lines of "please help me do X" (often without the "please") or "my use case doesn't work, figure out what's...
> Does it need be exposed in the public API? > > Why not simply always force it in `chrome74.ts` until it's done by the implementation itself? No need to...