iamkun comments

Results 196 comments of


                                            iamkun

Fixes issue #2442 Time validation Fix for other languages

Thanks for the PR. It fixed the bug in the related issue. However, is it possible not to add `meridiemHour` function to the locale file? Instead of using `meridiem` as...

Add "calendar" to language "fr"

Thanks

Add "calendar" to language "fr"

Can you please fix the lint error? Also, is it better to keep the same calendar config as moment.js fr locale?

refactor: optimize isToday, isTomorrow and isYesterday performance

amazing!

fix: update `monthDiff` remove number conversion

what's this PR for, please?

fix: update `monthDiff` remove number conversion

This function is from momentjs, you can check their test to see the edge case here

shortened up the wrong translated month with 3 characters

Thanks. It will be better if some native speaker cloud review this PR

Persian [fa] Farsi locale : Change relativeTime > future

Hi, we do keep the same with moment.js here https://github.com/moment/moment/blob/develop/locale/fa.js#L70

Persian [fa] Farsi locale : Change relativeTime > future

try https://day.js.org/docs/en/plugin/update-locale

Persian [fa] Farsi locale : Change relativeTime > future

Waiting for native speaker review ( 0 / 2 )