iamkun comments

Results 196 comments of


                                            iamkun

Question / Feature request regarding localized time format

Yes, Day.js do not read the user's locale, `en` locale by default, while you can change to some other one.

Question / Feature request regarding localized time format

Yes, maybe we could support it via another plugin. However, ATM, you have to set the correct locale by yourself.

Question / Feature request regarding localized time format

LocalizedFormat plugin is based on the locale you passed in

Update es-mx.js

Any reason for doing this, please?

fix: parsing timestamp in seconds in timezone plugin

Thanks. If we want to properly parse `dayjs.tz(1690278073, 'X')` from timestamp to date, maybe updating the logic in the costomParseFormat plugin is better? Not to hard code the logic in...

Fix for UTC plugin type definitions in combination with CustomParseFormat plugin

Thanks

fix: better nil check on utils

Thanks. But I don't think `''` is a valid date in js.

fix: better nil check on utils

Alright, I do think adding a custom plugin to parse `''` is a better choice. Cause if we accept this PR, it will also affect a lot of projects that...

fix: Duration.constructor()/toISOString()/add()/subtract() does not work properly

Thanks, I'll need some time to review this cool PR

fix: incorrect startOf/endOf behavior with +00:00 timezone

Thanks. It is odd that the PR sent from your account could not trigger the CI. But the rest looks fine.