iamkun
Persian [fa] Farsi locale : Change relativeTime > future
Hello Change relativeTime > future string with the correct mean in Farsi.
Codecov Report
Merging #815 (473a142) into dev (28a2207) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## dev #815 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 157 179 +22
Lines 1148 1996 +848
Branches 215 507 +292
==========================================
+ Hits 1148 1996 +848
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/locale/fa.js | 100.00% <ø> (ø) |
|
| src/index.js | 100.00% <0.00%> (ø) |
|
| src/utils.js | 100.00% <0.00%> (ø) |
|
| src/locale/ar.js | 100.00% <0.00%> (ø) |
|
| src/locale/bg.js | 100.00% <0.00%> (ø) |
|
| src/locale/bi.js | 100.00% <0.00%> (ø) |
|
| src/locale/bn.js | 100.00% <0.00%> (ø) |
|
| src/locale/br.js | 100.00% <0.00%> (ø) |
|
| src/locale/ca.js | 100.00% <0.00%> (ø) |
|
| src/locale/cs.js | 100.00% <0.00%> (ø) |
|
| ... and 79 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 28a2207...473a142. Read the comment docs.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi, we do keep the same with moment.js here https://github.com/moment/moment/blob/develop/locale/fa.js#L70
In Farsi, this sentence has no correct meaning.
Another way to customize this string?
as a native speaker can confirm that, the change presents the meaning, better.
I want to suggest another word, This is means "After". In Farsi «بعد»
definitely "بعد %s" is the best option. "%s آینده" is worse than "در %s". don't merge this pr. update your code with "بعد %s" and push again.
I also think "بعد" is a better option.
@iamkun This PR has received 2 reviews from native speakers. Please consider merging it.
