iamkun comments

Results 196 comments of


                                            iamkun

dayjs fromNow returns Invalid Date

https://runkit.com/embed/iol116brss5g

Dayjs does not preserve timezone information when serializing to JSON string

As JSON will serialize Dayjs object to an ISO 8601 string. https://day.js.org/docs/en/display/as-json However, if you want to customize this function, you can write your own plugin to modify it. https://day.js.org/docs/en/plugin/plugin...

Dayjs does not preserve timezone information when serializing to JSON string

Yes, just update it in your project's `index.js` file and the new dayjs is available in the global scope.

fix: customParseFormat strict mode bug when parsing with timezones (#929)

Would you please add the relevant test, please?

fix: customParseFormat strict mode bug when parsing with timezones (#929)

Thanks for the PR, need some time to review this.

fix: customParseFormat strict mode bug when parsing with timezones (#929)

Just a small concern, can we re-order the logic a little bit? Cause to me, it's a little complicated to understand the code of this PR.

#1118 - Partial Locale update added

Thanks. It will be better not using `Object.assign`, cause babel will bundle a huge polyfill to make it work on old browsers.

#1118 - Partial Locale update added

It's not about the syntax itself, but the whole bundle size while compiling it to es5.

#1118 - Partial Locale update added

Thanks, would you please move the utils function to the plugin file?

#1118 - Partial Locale update added

sorry that I didn't make it clear, what I mean is to move the extend function to `src/plugin/updateLocale/index.js` or maybe `src/plugin/updateLocale/utils.js`