iamkun
iamkun
LGTM, would you like to add some unit tests for this feature?
pls check my comment #2281
can you provide the OS version. And what's the result of `Array(2)`
after careful thought, the main issue leading to this bug is not related to the display `get` getter, but the setter and the constructor. dayjs.duration({ minutes: 359 }).toJSON() should return...
after checking the PR again, still I think, we should update the input part (setter and the constructor) to make the inner data correct, not in the output part What...
same #1600
please add the missing part of the locale config according to https://day.js.org/docs/en/customization/customization also, please add some unit test to make the CI green. cheers
Maybe we could update sl.js locale like https://github.com/moment/moment/blob/develop/src/locale/sl.js ref: https://github.com/iamkun/dayjs/blob/dev/src/locale/uk.js#L13
there should be no problem with localizedFormat plugin https://runkit.com/embed/yzvddg5czfg6
For consistent results parsing anything other than ISO 8601 strings, you should use String + Format. https://day.js.org/docs/en/parse/string-format