valkey icon indicating copy to clipboard operation
valkey copied to clipboard

Update COPYING to Valkey

Open PatrickJS opened this issue 1 year ago • 4 comments

Update COPYING to Valkey

PatrickJS avatar Mar 26 '24 04:03 PatrickJS

Not appropriate and not legally sound.

natoscott avatar Mar 26 '24 04:03 natoscott

Not appropriate and not legally sound.

^ this was because I originally backdated the copyright which was my fault. I updated it to the correct dates


ok, well now this is more correct until the rename (again my vote is OpenKV, OpenKVS)

PatrickJS avatar Mar 26 '24 06:03 PatrickJS

@madolson ok everything fixed and signed 🙏

PatrickJS avatar Apr 01 '24 02:04 PatrickJS

I updated to include both old and new since the old one had Redis in it

* Neither the name of Redis nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission.

PatrickJS avatar Apr 01 '24 03:04 PatrickJS

@PatrickJS Please rebase and fix the error in CI, Thanks

hwware avatar Apr 23 '24 14:04 hwware

@hwware rebased the ci error is likely because the pr was outdated

PatrickJS avatar Apr 24 '24 03:04 PatrickJS

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.39%. Comparing base (669f1d3) to head (f375269). Report is 3 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable      #32      +/-   ##
============================================
+ Coverage     68.33%   68.39%   +0.06%     
============================================
  Files           108      108              
  Lines         61562    61562              
============================================
+ Hits          42066    42103      +37     
+ Misses        19496    19459      -37     

see 14 files with indirect coverage changes

codecov[bot] avatar Apr 24 '24 14:04 codecov[bot]

@madolson do you think we could merge this PR? Thanks

hwware avatar Apr 24 '24 14:04 hwware

@hwware @madolson done

PatrickJS avatar Apr 24 '24 20:04 PatrickJS

all green, thanks (I don't have merge button)

PatrickJS avatar Apr 24 '24 20:04 PatrickJS