Pengfei He
Pengfei He
One issue with either make pack optional or add parameter `skip_add` is that for ontology subclasses, they all need to have such a parameter/optional datapack therefore it involves a lot...
> more comments added as annotations. > > please also check the grammar with some tools. fixed it.
> I removed the resolved ones but there are still a few left, should simply need some quick-fixes fixed them.
I think currently our implementation can already compute overlapping between `ImageAnnotation` here https://github.com/asyml/forte/blob/8a61272fe2dd7d3f266f4d66a2f0d3e8f6fc3389/forte/data/ontology/top.py#L936. For support like `region.get(Box)`, we can build a grid in the DataPack and a dictionary stores image...
`PIL` is a third-party python image library.
Overall it's a good tutorial, and I don't have much input. I can approve it after the misspelling is fixed and the issue is linked.
Thanks for adding more tests for the `Box` ontology. There are more features and complete design for `Box` implemented in https://github.com/asyml/forte/pull/827/files Could you pause this PR for a while and...
A review on the draft would be helpful for further implementation.
Reminder for changes https://github.com/asyml/forte/pull/891#discussion_r931670605
I have tried the code on GPU and it's working. However, the cuda driver/toolkit and package setup takes some time.