forte icon indicating copy to clipboard operation
forte copied to clipboard

Integrating CV Ontologies with the DataStore format

Open Pushkar-Bhuse opened this issue 3 years ago • 2 comments

This PR fixes #840 .

Description of changes

This PR mainly includes fine-tuning CV ontologies to be used correctly with the DataStore setup. Once this was completed, we included test cases (both from the users point of view and also from the DataStore's perspective) to validate the working of these ontologies.

Possible influences of this PR.

After this PR, DataStore can also include CV ontologies.

Test Conducted

Apart from data store specific functions, we tested addition, deletion and updating annotations, compute_iou and check_overlap method. These tests were conducted on the following ontologies

  • ImageAnnotation
  • Region
  • Box
  • BoundingBox

Pushkar-Bhuse avatar Jun 29 '22 17:06 Pushkar-Bhuse

Codecov Report

Merging #844 (db8a5d9) into master (8e03abe) will decrease coverage by 0.09%. The diff coverage is 69.14%.

@@            Coverage Diff             @@
##           master     #844      +/-   ##
==========================================
- Coverage   80.75%   80.65%   -0.10%     
==========================================
  Files         254      254              
  Lines       19364    19684     +320     
==========================================
+ Hits        15637    15877     +240     
- Misses       3727     3807      +80     
Impacted Files Coverage Δ
forte/data/ontology/core.py 69.69% <32.55%> (-7.23%) :arrow_down:
forte/data/ontology/top.py 73.31% <53.40%> (-2.45%) :arrow_down:
tests/forte/image_annotation_test.py 99.22% <99.08%> (-0.78%) :arrow_down:
forte/common/constants.py 100.00% <100.00%> (ø)
forte/data/entry_converter.py 83.95% <100.00%> (+0.61%) :arrow_up:
tests/forte/data/data_store_test.py 95.75% <100.00%> (+0.27%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8e03abe...db8a5d9. Read the comment docs.

codecov[bot] avatar Jun 29 '22 18:06 codecov[bot]

Thanks for adding more tests for the Box ontology. There are more features and complete design for Box implemented in https://github.com/asyml/forte/pull/827/files Could you pause this PR for a while and edit it after PR837 is merged?

hepengfe avatar Jun 29 '22 18:06 hepengfe