forte icon indicating copy to clipboard operation
forte copied to clipboard

add notebook tags and tests

Open hepengfe opened this issue 3 years ago • 1 comments

This PR fixes https://github.com/asyml/forte/issues/887

Description of changes

  • add tags to docs/notebook_tutorial/ocr.ipynb for notebook tests
  • add notebook tests for docs/notebook_tutorial/ocr.ipynb

Possible influences of this PR.

Describe what are the possible side-effects of the code change.

Test Conducted

tested all code cells that don't require users' prompts

hepengfe avatar Jul 25 '22 22:07 hepengfe

Codecov Report

Merging #889 (f39f591) into master (fe632e6) will increase coverage by 0.22%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #889      +/-   ##
==========================================
+ Coverage   80.78%   81.00%   +0.22%     
==========================================
  Files         254      254              
  Lines       19388    19583     +195     
==========================================
+ Hits        15662    15864     +202     
+ Misses       3726     3719       -7     
Impacted Files Coverage Δ
forte/utils/utils.py 76.74% <0.00%> (-0.60%) :arrow_down:
tests/forte/remote_processor_test.py 100.00% <0.00%> (ø)
tests/forte/utils/tagging_scheme_test.py 100.00% <0.00%> (ø)
tests/forte/data/datapack_type_infer_test.py 100.00% <0.00%> (ø)
...rte/processors/ir/bert_based_query_creator_test.py 100.00% <0.00%> (ø)
...essors/data_augment/base_data_augment_processor.py 98.38% <0.00%> (+<0.01%) :arrow_up:
...rs/base/data_augment_replacement_processor_test.py 99.43% <0.00%> (+<0.01%) :arrow_up:
tests/forte/data/vocabulary_test.py 99.09% <0.00%> (+0.01%) :arrow_up:
forte/data/readers/ontonotes_reader.py 95.79% <0.00%> (+0.01%) :arrow_up:
tests/forte/advanced_pipeline_test.py 99.00% <0.00%> (+0.02%) :arrow_up:
... and 78 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jul 25 '22 22:07 codecov[bot]

I have added more comments on the doc directly, please take a look: https://asyml-forte--889.org.readthedocs.build/en/889/notebook_tutorial/ocr.html

hunterhector avatar Aug 19 '22 17:08 hunterhector

more comments added as annotations.

please also check the grammar with some tools.

hunterhector avatar Aug 22 '22 16:08 hunterhector

more comments added as annotations.

please also check the grammar with some tools.

fixed it.

hepengfe avatar Aug 29 '22 17:08 hepengfe

There are still some unresolved comments in https://asyml-forte--889.org.readthedocs.build/en/889/notebook_tutorial/ocr.html. Could you reply on that page of how you address these comments?

mylibrar avatar Aug 29 '22 19:08 mylibrar

I removed the resolved ones but there are still a few left, should simply need some quick-fixes

hunterhector avatar Aug 31 '22 15:08 hunterhector

I removed the resolved ones but there are still a few left, should simply need some quick-fixes

fixed them.

hepengfe avatar Sep 02 '22 01:09 hepengfe