Audio tutorial
This issue is part of #691 This PR fixes #850
Description of changes This tutorial is an introduction to the Automatic speech translation using Forte
Codecov Report
Merging #846 (4f69432) into master (e86602f) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## master #846 +/- ##
=======================================
Coverage 80.91% 80.91%
=======================================
Files 254 254
Lines 19551 19551
=======================================
Hits 15819 15819
Misses 3732 3732
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
please add an issue to track this pr, thanks
Overall it's a good tutorial, and I don't have much input. I can approve it after the misspelling is fixed and the issue is linked.
The file is too large and we should keep the master lean. We should move the assets (images) to this branch (https://github.com/asyml/forte/tree/assets)
please add an issue to track this pr, thanks
done
Overall it's a good tutorial, and I don't have much input. I can approve it after the misspelling is fixed and the issue is linked.
fixed
The file is too large and we should keep the master lean. We should move the assets (images) to this branch (https://github.com/asyml/forte/tree/assets)
image referred from URL, to keep master lean
A couple suggestions:
- The notebook file is still 2.7 MB (after image removal), if this is plain text it shouldn't be that large, maybe there is some output that should be removed too? The size should be a couple of k.
reduced the size to 184k, (removed the almost all audio play outputs)
- When asking users to click and listening to audio, probably should specify what's required (for example, it won't work if the notebook is run on a server without audio output).
mostly it will use the user's laptop or PC to play the audio, still, I have mentioned the requirement.
- Some explanation needs to be made to the Forte processors, for example, what are the "AudioUtterances", why are we adding the "Link"s. Eventually, this is a
Fortetutorial more than ASR, we need to teach more about Forte and how it helps with managing the data. This is the main issue of the tutorial.
added context on "AudioUtterances" and "link". and why we are using it.
- The part that plays
seg[1]toseg[3]is a bit repetitive.
Now just playing one segment only.
Let’s add test cases here: https://github.com/asyml/forte/tree/master/tests/forte/notebooks
Let’s add test cases here: https://github.com/asyml/forte/tree/master/tests/forte/notebooks
done.