forte icon indicating copy to clipboard operation
forte copied to clipboard

Audio tutorial

Open bhaskar2443053 opened this issue 3 years ago • 9 comments

This issue is part of #691 This PR fixes #850

Description of changes This tutorial is an introduction to the Automatic speech translation using Forte

bhaskar2443053 avatar Jul 01 '22 14:07 bhaskar2443053

Codecov Report

Merging #846 (4f69432) into master (e86602f) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #846   +/-   ##
=======================================
  Coverage   80.91%   80.91%           
=======================================
  Files         254      254           
  Lines       19551    19551           
=======================================
  Hits        15819    15819           
  Misses       3732     3732           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jul 01 '22 14:07 codecov[bot]

please add an issue to track this pr, thanks

hunterhector avatar Jul 01 '22 15:07 hunterhector

Overall it's a good tutorial, and I don't have much input. I can approve it after the misspelling is fixed and the issue is linked.

hepengfe avatar Jul 01 '22 18:07 hepengfe

The file is too large and we should keep the master lean. We should move the assets (images) to this branch (https://github.com/asyml/forte/tree/assets)

hunterhector avatar Jul 01 '22 18:07 hunterhector

please add an issue to track this pr, thanks

done

bhaskar2443053 avatar Jul 02 '22 07:07 bhaskar2443053

Overall it's a good tutorial, and I don't have much input. I can approve it after the misspelling is fixed and the issue is linked.

fixed

bhaskar2443053 avatar Jul 02 '22 07:07 bhaskar2443053

The file is too large and we should keep the master lean. We should move the assets (images) to this branch (https://github.com/asyml/forte/tree/assets)

image referred from URL, to keep master lean

bhaskar2443053 avatar Jul 03 '22 07:07 bhaskar2443053

A couple suggestions:

  1. The notebook file is still 2.7 MB (after image removal), if this is plain text it shouldn't be that large, maybe there is some output that should be removed too? The size should be a couple of k.

reduced the size to 184k, (removed the almost all audio play outputs)

  1. When asking users to click and listening to audio, probably should specify what's required (for example, it won't work if the notebook is run on a server without audio output).

mostly it will use the user's laptop or PC to play the audio, still, I have mentioned the requirement.

  1. Some explanation needs to be made to the Forte processors, for example, what are the "AudioUtterances", why are we adding the "Link"s. Eventually, this is a Forte tutorial more than ASR, we need to teach more about Forte and how it helps with managing the data. This is the main issue of the tutorial.

added context on "AudioUtterances" and "link". and why we are using it.

  1. The part that plays seg[1] to seg[3] is a bit repetitive.

Now just playing one segment only.

bhaskar2443053 avatar Jul 29 '22 06:07 bhaskar2443053

Let’s add test cases here: https://github.com/asyml/forte/tree/master/tests/forte/notebooks

hunterhector avatar Aug 09 '22 13:08 hunterhector

Let’s add test cases here: https://github.com/asyml/forte/tree/master/tests/forte/notebooks

done.

bhaskar2443053 avatar Aug 17 '22 09:08 bhaskar2443053