Dan Hemberger

Results 70 comments of Dan Hemberger

I meant to add that it's also a little weird that we have a base 3% chance reduction, and then the smuggling ship reduces that chance to -1%. Maybe it...

Yeah, I was thinking the alternative would be to have a real `createPort` method that fails if the port already exists. But this solution seemed like less trouble. I don't...

![image](https://user-images.githubusercontent.com/846186/36878872-ce9146be-1d75-11e8-8d4b-847d39fbf304.png) ![image](https://user-images.githubusercontent.com/846186/36878892-ea54c826-1d75-11e8-8aa7-1247879ce8d3.png)

@Page- I was wondering if you had any comments about this draft, since it would take a lot of work to get it into a polished/final state.

This idea has been floated before, and I can see the rationale behind it, but it seems like it adds a bit too much complexity without adding much depth. It...

These are all good points, and I will do my best to consider your ideas when I get back to working on this issue. Thank you for the feedback!

This simplified diagram of the logic illustrates how the error is impossible to trigger in a single-threaded case. ``` if (session_id exists in database) { generate = false } else...

This is my experience with v2 as well. In v1, all my relative markdown links rendered correctly in HTML, so this seems like a pretty serious regression. The only thing...

Thanks for reporting this issue! So libxml2 2.14 is more strict about closing ``, but it's still okay to have unclosed ``? Presumably this can be fixed by adding ``....

@moy Just wondering if you have any thoughts about this change. Thanks!