Remove port search reduction per evil good and incorporate in a base chance reduction to 4%

[Page-]

[codecov[bot]]

Codecov Report

Merging #976 (5156d0c) into master (91d142c) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##             master    #976   +/-   ##
========================================
  Coverage      2.75%   2.75%           
  Complexity     4062    4062           
========================================
  Files            74      74           
  Lines         11200   11200           
========================================
  Hits            308     308           
  Misses        10892   10892           

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91d142c...5156d0c. Read the comment docs.

[hemberger]

I meant to add that it's also a little weird that we have a base 3% chance reduction, and then the smuggling ship reduces that chance to -1%. Maybe it should be changed so the resulting chance is 0% instead, but obviously that doesn't matter from a gameplay perspective.

[stupidnewbie]

Lowering alignment is pretty straightforward. Just shoot low level ports. If you can't find a race you're at peace with just use neutral ports. It's faster and more turn efficient than careening around with contraband having to click every port. Plus you gain credits looting the ports.

I've got more concern over losing the positive alignment gained from clean checks. That extra few dozen points you get being checked while trading early on helps you stay green. It's not a huge deal as long as you can constantly re-deputize and I won't rant about that loophole here.

It strikes me as more reasonable to set a higher check percent and then simply reduce it to 0 via smuggling ship bonus. I'd guess something like 6% might be closer to realistic. But I'm only guessing. A few DB queries would probably shed better light on that.

I do like the simplified calculation. It's less crap to look up or remember. And I do believe the smuggling craft bonus should be more substantial. Right now it's good for 3 or 4 percent which is not a significant amount of the 1920 trade potential a Thief has.