Dan Hemberger

Results 70 comments of Dan Hemberger

I agree with @maximino-dev that updating the pipfiles to a >=2.0 constraint on werkzeug and exclusively using `Response` is probably the best progressive solution. However, if the higher priority is...

I think @maximino-dev's solution covers all the bases. However, it seems a shame to encode the complicated history of werkzeug into this library. Perhaps we could just add a werkzeug...

@mnapoli When you have a moment to spare, I'd be really grateful to hear your thoughts about this PR. Is it fundamentally a non-starter for you, or are there aspects...

Thanks for the response, and I certainly appreciate your need to carefully weigh whether or not to add to the API! While I can't speak for anyone else, what I...

Thanks all for your feedback on this PR. I suppose I'm coming at this from the perspective of a legacy project (20+ years old) that I've been laboriously modernizing for...

Thanks for your detailed reply @SvenRtbg! If it is inappropriate to continue the discussion here, please let me know (though I am finding it immensely helpful). > I once had...

> Have you tried adding the constant to this config option? https://phpstan.org/config-reference#constants Thanks for the quick reply! Yes, I have tried using `dynamicConstantNames`, but the result is the same (in...

Yes, the import will need to be aliased. @maximino-dev would you be willing to update your PR to address this point? Thanks!

Hi, and thanks for reporting this! I agree that there should be some fix for `stream=True` (or at least documentation to describe how it does/doesn't work). At the moment I'm...

When I visit that link, it says there are no issues. There are 3 "use of exec" ignored issues. Perhaps they updated their software and fixed some false positives? By...