Dan Hemberger

Results 70 comments of Dan Hemberger

Thanks for your thoughtful and detailed analysis of this issue! I agree completely that in an ideal world it would be easy to do things the robust way and hard...

Great suggestion! I'm 100% on board with adding type annotations. I'll let this sit for a while in case anyone wants to use this as a way to get involved...

@gophra Thanks for offering to get involved! As far as I understand, type annotations can be added incrementally, so I think getting some infrastructure for _testing_ the type annotations would...

Since the `btnName` argument of `StatefulBrowser.submit_selected` is just forwarded to `Form.choose_submit`, a bs4.element.Tag can be passed to either method. To answer the original question explicitly, you can do something like...

One thing that makes me vaguely hesitant about this change is users getting confused about when the response is updated. For example, `download_link` (for well-motivated reasons) does not update the...

I was afraid that might be the case. We probably should have made the response + soup object a new class, rather than hijack the response object. I guess that's...

This pull request **introduces 1 alert** when merging f681e7ba1df5515572f7d8bb351a8dca79ee66da into 730ca4a5948a6573994da24c6da26df82da533b6 - [view on LGTM.com](https://lgtm.com/projects/g/MechanicalSoup/MechanicalSoup/rev/pr-990650db5be36f008bf2bf71cdedda09cb393dd9) **new alerts:** * 1 for Mismatch between signature and use of an overridden method ---...

Great question, thanks for asking! The Requests session has a few methods for cookiejar manipulation, and I could definitely envision adding a `set_cookie` method to MechanicalSoup that wraps one of...

Thanks for the clarification. Hmm, what about something like this? ```python from http.cookies import SimpleCookie cookie_jar = browser.get_cookiejar() for raw_cookie in raw_cookies_from_js: cookie = SimpleCookie(raw_cookie) cookie_jar.set_cookie(cookie) ```

Thanks for your follow-up. I guess I was naive in thinking that such a straightforward solution would be possible! It does seem frustrating, but I think that having a hack...