Héctor Gómez

Results 23 issues of Héctor Gómez

## Summary The native coins and token prices are being retrieved from a third-party service (currently CoinGecko). The configuration data for each chain is _hard-coded_ in the CGW code: https://github.com/safe-global/safe-client-gateway/blob/3df9a2423911460b9b5f5298dbb0d93ea2f05e1a/src/config/entities/configuration.ts#L31...

enhancement

## Summary In the process of updating to ESLint 9, some rules were temporarily ignored due to changes in their recommendations. One of these rules was the [`@typescript-eslint/no-unsafe-argument`](https://typescript-eslint.io/rules/no-unsafe-argument) rule. This...

## Summary In the process of updating to ESLint 9, some rules were temporarily ignored due to changes in their recommendations. One of these rules was the [`@typescript-eslint/no-unnecessary-type-assertion`](https://typescript-eslint.io/rules/no-unnecessary-type-assertion) rule. This...

## Summary While upgrading to ESLint 9, certain rules were temporarily ignored due to changes in their recommendations. One such rule was the [`@typescript-eslint/no-redundant-type-constituents`](https://typescript-eslint.io/rules/no-redundant-type-constituents) rule. This PR addresses instances where...

## Summary When updating to ESLint 9, some rules had to be ignored as their recommendations changed. Of which, was the [`@typescript-eslint/no-misused-promises`](https://typescript-eslint.io/rules/no-misused-promises/) rule. ## Changes - Enable `@typescript-eslint/no-misused-promises` ESLint rule...

## Summary This PR changes the source for the Prices Provider (currently CoinGecko) configuration from the CGW hardcoded (`configuration.ts`) one, by the `Chain` entity coming from the Safe Config Service....

### Description There are many ERC20 contracts where the Safe Transaction Service holds the token metadata available (displayName, logoUri) in the `/token/{address}` endpoint, but it's missing on our `/contract/{address}` endpoint....

enhancement

**Dependencies** - [ ] Centralise schemas and data validation (TODO: link to issue) Context [here](https://github.com/5afe/safe-client-gateway-nest/pull/66#discussion_r959772023). **Summary** Currently, as shown in the context link, we have some inconsistencies between the current...

Blocked

## Summary Some `Campaign` field names have been changed from the Safe Locking Service original specification. Specifically: - `periodStart` has been renamed as `startDate`. - `periodEnd` has been renamed as...

## Changes - Adds the following endpoints to the service: - `GET /api/v1/locking/campaigns` - `GET /api/v1/locking/campaigns/:campaignId`