safe-client-gateway
safe-client-gateway copied to clipboard
Fix @typescript-eslint/no-unsafe-argument instances
Summary
In the process of updating to ESLint 9, some rules were temporarily ignored due to changes in their recommendations. One of these rules was the @typescript-eslint/no-unsafe-argument
rule.
This PR re-enables the @typescript-eslint/no-unsafe-argument
rule and addresses instances where redundant type constituents were used.
Changes
- Enable
@typescript-eslint/no-unsafe-argument
ESLint rule ineslint.config.mjs
- Define types for arguments passed to functions.
- Add type-checks.
Pull Request Test Coverage Report for Build 9364217341
Details
- 16 of 19 (84.21%) changed or added relevant lines in 9 files are covered.
- 4 unchanged lines in 3 files lost coverage.
- Overall coverage increased (+0.04%) to 92.84%
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
---|---|---|---|
src/datasources/balances-api/zerion-balances-api.service.ts | 0 | 3 | 0.0% |
<!-- | Total: | 16 | 19 |
Files with Coverage Reduction | New Missed Lines | % |
---|---|---|
src/routes/common/address-info/address-info.helper.ts | 1 | 88.89% |
src/datasources/balances-api/zerion-balances-api.service.ts | 1 | 81.22% |
src/routes/transactions/entities/tests/human-description.builder.ts | 2 | 80.0% |
<!-- | Total: | 4 |
Totals | |
---|---|
Change from base Build 9352060400: | 0.04% |
Covered Lines: | 7120 |
Relevant Lines: | 7379 |