safe-client-gateway
safe-client-gateway copied to clipboard
Fix @typescript-eslint/no-misused-promises instances
Summary
When updating to ESLint 9, some rules had to be ignored as their recommendations changed. Of which, was the @typescript-eslint/no-misused-promises
rule.
Changes
- Enable
@typescript-eslint/no-misused-promises
ESLint rule - Changes the
Promise
returns to sync functions returningvoid
in:-
src/datasources/cache/redis.cache.service.ts
-
src/datasources/queues/queues-api.service.ts
-
Pull Request Test Coverage Report for Build 9034080022
Details
- 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
- 1 unchanged line in 1 file lost coverage.
- Overall coverage remained the same at 92.994%
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
---|---|---|---|
src/datasources/cache/redis.cache.service.ts | 1 | 2 | 50.0% |
<!-- | Total: | 3 | 4 |
Files with Coverage Reduction | New Missed Lines | % |
---|---|---|
src/routes/transactions/entities/tests/human-description.builder.ts | 1 | 90.0% |
<!-- | Total: | 1 |
Totals | |
---|---|
Change from base Build 9023794730: | 0.0% |
Covered Lines: | 6984 |
Relevant Lines: | 7235 |